Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): Compare location against basename-prefixed route. #9076

Merged
merged 2 commits into from Sep 20, 2023

Conversation

onurtemizkan
Copy link
Collaborator

Fixes: #9061

Following up: #8457 which apparently did not cover parameterized paths.

Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.61 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.51 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 22.11 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.29 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.61 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.67 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 222.19 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.68 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.53 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.48 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.63 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 22.14 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.51 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.09 KB (+0.04% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) September 20, 2023 17:08
@AbhiPrasad AbhiPrasad merged commit 27cf07f into develop Sep 20, 2023
56 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/fix-react-router-6-basename branch September 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized paths not picked up when using react-router-v6 with basename
2 participants