Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Fix RequestAsyncStorage fallback path #9126

Merged
merged 1 commit into from Sep 27, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Sep 27, 2023

Fixes bug reported in #9092 (comment)

This code path is in theory an invariant but people seem to be hitting it and the fallback started failing because the path was wrong.

@lforst lforst merged commit 647c7b9 into develop Sep 27, 2023
49 checks passed
@lforst lforst deleted the lforst-fix-request-async-storage-fallback-path branch September 27, 2023 11:53
@Burry
Copy link

Burry commented Oct 3, 2023

I'm afraid this is still causing issues with Next.js 13.5.4, blocking an app build. I wish Vercel would release a stable hook into RequestAsyncStorage, too much magic

@lforst
Copy link
Member Author

lforst commented Oct 4, 2023

@Burry If this is still an issue for you on 7.73.0 please open an issue describing the problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants