fix(core): Ensure tunnel is considered for isSentryUrl checks
#9130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also streamline these and use the same util in all places.
mydea
commented
Sep 27, 2023
| const protocol = requestOptions.protocol || ''; | ||
| const hostname = requestOptions.hostname || requestOptions.host || ''; | ||
| // Don't log standard :80 (http) and :443 (https) ports to reduce the noise | ||
| // Also don't add port if the hostname already includes a port |
There was a problem hiding this comment.
Also noticed that host may include the port (e.g. localhost:3000), so we better check that this is not the case before re-adding the port.
AbhiPrasad
approved these changes
Sep 27, 2023
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also streamline these and use the same util in all places.