Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ember): Drop undefined config values #9175

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 4, 2023

It seems to trip something up somewhere when config is undefined, so we just remove these here to avoid this. These options are serialized etc. so there may be something weird going on there...

Fixes #9168

@mydea mydea requested review from lforst and Lms24 October 4, 2023 10:12
@mydea mydea self-assigned this Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.24 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (0%)
@sentry/browser - Webpack (gzipped) 22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.77 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.59 KB (+0.26% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21 KB (+2.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.38 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.66 KB (+0.28% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.35 KB (+1.84% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.45 KB (+0.24% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.27 KB (0%)
@sentry/react - Webpack (gzipped) 22.05 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.23 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.99 KB (-0.03% 🔽)

It seems to trip something up somewhere when config is undefined, so we just remove these here to avoid this.
@mydea mydea force-pushed the fn/ember-drop-undefined-keys branch from 316f030 to e2a1205 Compare October 4, 2023 11:39
@mydea mydea merged commit b332327 into develop Oct 4, 2023
44 checks passed
@mydea mydea deleted the fn/ember-drop-undefined-keys branch October 4, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Error (TerserWriter) with @sentry/ember 7.73.0
3 participants