chore(astro): Add Astro integration keywords #9193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/astro-integration-keywords
branch
from
2198f3f
to
e49337c
Compare
|
Let's ask astro if we can add a monitoring/developer tooling category for their integrations cc @HazAT |
Lms24
force-pushed
the
lms/astro-integration-keywords
branch
from
e49337c
to
43c994c
Compare
Lms24
commented
Oct 12, 2023
packages/astro/package.json
Outdated
| "keywords": [ | ||
| "withastro", | ||
| "astro-component", | ||
| "analytics", |
There was a problem hiding this comment.
Talked to Astro folks. They'll add a new category sometime next week. For now, we remove analytics. Can add the new category later on.
Suggested change
| "analytics", |
AbhiPrasad
approved these changes
Oct 12, 2023
Lms24
force-pushed
the
lms/astro-integration-keywords
branch
from
3d8a4a9
to
0ffe696
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding specific keywords to an NPM package makes them show up in Astro's integration library page. This PR adds them to the Astro package.json.
When we're ready we should also file an issue with Astro to add a Sentry logo in the library.
Separate PR because I'd only merge this once we're comfortable with publishing.
ref #9182