Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-experimental): Use new Propagator for OTEL Spans #9214

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 10, 2023

This fixes the propagator for node-experimental.

The "old" propagator from opentelemetry-node relies on having a transaction for the active span etc, which we don't have anymore. So the propagator never attached the correct stuff etc.

So now there is a new propagator for node-experimental:

  • Instead of keeping DSC & TraceparentData on the OTEL Context, we just keep the PropagationContext (which includes the DSC...)
  • Add an E2E test to make sure we attach the outgoing header correctly

@mydea mydea requested review from lforst and Lms24 October 10, 2023 13:18
@mydea mydea self-assigned this Oct 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84.22 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.41 KB (0%)
@sentry/browser - Webpack (gzipped) 22 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 78.78 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.6 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.02 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 254.47 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.75 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.44 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.46 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.05 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.22 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.99 KB (0%)

@mydea mydea force-pushed the fn/node-experimental-propagator branch from 5a7adc3 to 403c7ca Compare October 10, 2023 14:19
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me!

@mydea mydea force-pushed the fn/node-experimental-propagator branch 2 times, most recently from ed637d8 to 4eeac56 Compare October 11, 2023 09:07
@mydea mydea force-pushed the fn/node-experimental-propagator branch from 4eeac56 to f863c41 Compare October 11, 2023 10:52
@mydea mydea merged commit 2875cd9 into develop Oct 11, 2023
45 checks passed
@mydea mydea deleted the fn/node-experimental-propagator branch October 11, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants