-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Narrow filters for health check transactions #9257
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can always broaden certain ones again if needed 👍
@@ -428,6 +428,18 @@ describe('InboundFilters', () => { | |||
expect(eventProcessor(TRANSACTION_EVENT_HEALTH_2, {})).toBe(TRANSACTION_EVENT_HEALTH_2); | |||
expect(eventProcessor(TRANSACTION_EVENT_HEALTH_3, {})).toBe(TRANSACTION_EVENT_HEALTH_3); | |||
}); | |||
|
|||
it.each(['/delivery', '/already', '/healthysnacks'])( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this funny for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw before thinking of "already" my example for ready
was bready
👀 😅
As reported internally via Slack, our filters for health check transactions (which we unfortunately added to the SDK a while ago) were partially far too broad, filtering out transactions like
/delivery
because they matched the/^.*live.*$/
regex. This PR narrows down the regexes so that they no longer only require a partial but a full match.I'd still rather nuke the entire filters array, given that we filter on the backend anyway, but there's a point to be made that the filters in the SDK avoid unnecessary traffic to Relay.
ref getsentry/team-webplatform-meta#70