Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(astro): Add astro-integration keyword #9265

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 16, 2023

Turns out, to make our Astro package show up in Astro's integration library, we need to add another keyword that's only mentioned here and not in Astro's NPM publishing guide.

With this keyword added (and once we cut the next release), our SDK should show up in the library 馃

(I'd like to get this out relatively soonish so that we can write docs that actually use npx astro add as opposed to installing the package manually).

ref #9093

@Lms24 Lms24 enabled auto-merge (squash) October 16, 2023 15:05
@github-actions
Copy link
Contributor

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 83.98 KB (-0.34% 馃斀)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.57 KB (+0.48% 馃敽)
@sentry/browser - Webpack (gzipped) 21.75 KB (-1.2% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 80.47 KB (+2.15% 馃敽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.51 KB (+3.19% 馃敽)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.69 KB (+3.17% 馃敽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 245.55 KB (-3.53% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.53 KB (-1.43% 馃斀)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.45 KB (-1.62% 馃斀)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.64 KB (+3.69% 馃敽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.05 KB (-0.29% 馃斀)
@sentry/react - Webpack (gzipped) 21.79 KB (-1.21% 馃斀)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.18 KB (-0.03% 馃斀)
@sentry/nextjs Client - Webpack (gzipped) 49.65 KB (-2.57% 馃斀)

@Lms24 Lms24 merged commit fa00061 into develop Oct 17, 2023
47 checks passed
@Lms24 Lms24 deleted the lms/fix-astro-integration-keyword branch October 17, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants