Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): Streamline rrweb internal error check #9391

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 27, 2023

I think we don't really need this anymore, and this doesn't even work anyhow in any minified scenario, so we can safe these bundle bytes & also the work to check this on each error.

Or @billyvg do you see scenarios where this would catch something that the check above wouldn't? 馃

@mydea mydea requested a review from billyvg October 27, 2023 12:06
@mydea mydea self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 77.33 KB (-0.09% 馃斀)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 66.39 KB (-0.09% 馃斀)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 30.94 KB (0%)
@sentry/browser - Webpack (gzipped) 21.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.57 KB (-0.09% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.93 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 216.16 KB (-0.09% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 87.77 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 62.76 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.71 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 77.72 KB (-0.08% 馃斀)
@sentry/react - Webpack (gzipped) 21.29 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 94.06 KB (-0.06% 馃斀)
@sentry/nextjs Client - Webpack (gzipped) 47.83 KB (0%)

Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible we've missed applying our error handler in the rrweb codebase, but I agree we probably shouldn't rely on this as it's not very reliable.

I think we don't really need this anymore, and this doesn't even work anyhow in any minified scenario, so we can safe these bundle bytes & also the work to check this on each error.
@mydea mydea force-pushed the streamline-rrweb-error-check branch from b31cf70 to 1c41f3e Compare October 30, 2023 09:15
@mydea mydea merged commit a8cf899 into develop Oct 31, 2023
81 checks passed
@mydea mydea deleted the streamline-rrweb-error-check branch October 31, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants