fix(nextjs): Fix devserver CORS blockage when assetPrefix
is defined
#9766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8727
When
assetPrefix
is defined the webpack dev server will live on that prefixed domain.The SDK may attach tracing headers to the HMR server when the asset prefix is something like
http://cdn.localhost:3000
because we match on "localhost". Because this is then a different origin we run into CORS issues with the dev server.This PR resolves that by special casing the
tracePropagationTargets
when Next.js is in dev mode. This is a bit of a hack for now.Once we get to #9764 we can remove the hack again.