Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Add profile envelope types #9798

Merged
merged 2 commits into from Dec 12, 2023
Merged

feat(types): Add profile envelope types #9798

merged 2 commits into from Dec 12, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 12, 2023

As suggested here by @AbhiPrasad, this PR adds types for profile envelopes.

@timfish timfish mentioned this pull request Dec 12, 2023
Merged
AbhiPrasad
AbhiPrasad approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - will let Jonas confirm

@JonasBa
Copy link
Member

JonasBa commented Dec 12, 2023

Thank you @timfish!

@AbhiPrasad AbhiPrasad merged commit 13e3425 into getsentry:develop Dec 12, 2023
75 checks passed
@timfish timfish deleted the fix/profile-envelope-types branch December 12, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasBa JonasBa JonasBa approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timfish @JonasBa @AbhiPrasad