Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix): Do not capture thrown redirect responses. #9909

Merged
merged 1 commit into from Dec 19, 2023
Merged

fix(remix): Do not capture thrown redirect responses. #9909

merged 1 commit into from Dec 19, 2023

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Dec 19, 2023 •
edited

Fixes: #9906

Skips capturing all responses < 500 that end up in captureRemixServerException.

@onurtemizkan onurtemizkan marked this pull request as ready for review December 19, 2023 12:17
Lms24
Lms24 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lms24 Lms24 merged commit a856913 into develop Dec 19, 2023
61 checks passed
@Lms24 Lms24 deleted the onur/remix-thrown-redirects branch December 19, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry Remix integration reports thrown redirects as errors
2 participants
@onurtemizkan @Lms24