Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Update CHANGELOG for 7.90.0 #9932

Merged
merged 15 commits into from
Dec 20, 2023
Merged

meta: Update CHANGELOG for 7.90.0 #9932

merged 15 commits into from
Dec 20, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 20, 2023

Small release but let's get the fixes out

mydea and others added 15 commits December 19, 2023 14:42
Slowly getting rid of `getCurrentHub()`...
This is a try to move the application of scope data to events out of the
scope class into a util function.

This changes the flow to be:

1. The scope has a `getScopeData()` method that returns data that should
be applied to events.
2. The `prepareEvent` method uses that to actually apply scope data to
the event etc.
3. This also makes it much easier to do the experimentation in
node-experimental
(#9799) because we
only need to overwrite this, and can leave the rest of the event
processing the same.

I _think_ this makes sense but would appreciate some more eyes on this
as well. For me the separation makes also more sense, as e.g. the
application of event processors etc. should not really be tied to the
scope at all.

This is also is a first step to then allow us to add global scopes more
easily.

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
We've been using esbuild (default, from`@size-limit/preset-small-lib`)
for most jobs, but webpack for the one with custom config, which is a
bit inconsistent.

This now updates this to always use webpack, which should be more
consistent...

If we eventually get rid of the custom webpack config (e.g. when we
merge this or something like it:
#9826), we can revert
this back to use esbuild everywhere.
…e` (#9899)

Slowly getting rid of `getCurrentHub()`...
[Gitflow] Merge master into develop
This PR reworks Node ANR detection to use a worker thread. Workers are
usually started via a path to a source file but this can cause issues
when bundlers are used. Instead, the worker code is bundled and included
in the source as a base64 string which can be used to launch a worker
via a data URL. The base64 code comes in at around 45KB.

Positives 👍
- No extra processes
- Only 10-15MB memory overhead (vs at least 50MB for a child process)
- Uses inspector API so we can remove the websockets implementation
- Doesn't require special cases/setup for Electron main process
- No longer runs the app entry point again as the child process code
   - Closes some outstanding Electron ANR issues
- ANR becomes just an integration since we don't need to intercept app
execution in the child
   - Less confusing setup and less chance of running the app twice

Negatives 👎
- Minimum supported Node version for ANR detection becomes v16 because
Node 14 does not support data URLs for workers 😢

## Usage

```ts
import * as Sentry from '@sentry/node';

Sentry.init({
  dsn: 'https://public@dsn.ingest.sentry.io/1337',
  integrations: [new Sentry.Integrations.Anr({ captureStackTrace: true, anrThreshold: 200 })],
});
```
Instead of using canvas recording quality values direct to rrweb, use
presets to control image quality and fps.

Closes getsentry/team-replay#325
Refine the regex to match fewer errors, seeing some false positives in
replays that are not hydration errors.

fixes getsentry/sentry#61943
Eventually we may think about merging the `LinkedErrors` integration
with the core one, but for now this should be OK...
Also make a small adjustment to the legacy converter util to ensure
`setupOnce()` is callable with or without arguments, to remain stable.
Adds a `types` field to the `"."` subpath in the
`exports` object in package.json so that `svelte-check` type checking
finds the type declarations of the SDK in Kit 2.0.
@Lms24 Lms24 requested review from lforst and mydea December 20, 2023 13:48
@lforst lforst changed the base branch from develop to master December 20, 2023 13:48
@Lms24 Lms24 merged commit d02a96c into master Dec 20, 2023
24 checks passed
@Lms24 Lms24 deleted the prepare-release/7.90.0 branch December 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants