Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trimmed headers instead of cocoapods for Apple targets #74

Open
Tracked by #195
buenaflor opened this issue Apr 18, 2023 · 0 comments
Open
Tracked by #195

Use trimmed headers instead of cocoapods for Apple targets #74

buenaflor opened this issue Apr 18, 2023 · 0 comments

Comments

@buenaflor
Copy link
Contributor

buenaflor commented Apr 18, 2023

Problem

Currently we use cocoapods to pull in the Sentry Cocoa SDK dependency for Apple targets. This might create an overhead by also pulling in many headers that we don't use. (needs investigation how big this overhead actually is)

Solution

Grab and trim headers that we need so we only define the utmost minimum that we need to support the Cocoa SDK features that we are using and run cinterop on those.

We are already doing this for accessing private Sentry Cocoa SDK features: https://github.com/getsentry/sentry-kotlin-multiplatform/tree/main/sentry-kotlin-multiplatform/src/nativeInterop/cinterop

Testing

This will break internal tests on the cocoa side but that's easily fixable by just introducing the workaround mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants