Cron schedule not respection between

[rodolfoBee]

How do you use Sentry?

Sentry SaaS (sentry.io)

SDK version

3.8.2

Steps to reproduce

Similar to: #782

Example setup:

$schedule->job(....)
->everyFiveMinutes()
->between('9:00', '18:00')
->countries([Country::TR])
->sentryMonitor('__monitor_slug__')
->onOneServer();

Expected result

Monitor is updated with the crontab: */5 9-17 * * *
"Every 5 minutes, between 09:00 and 17:59"

Actual result

Monitor is update with crontab: */5 * * * *
"Every 5 minutes"

Same as the issue linked above, the workaround is to set updateMonitorConfig:false and manually config the monitor in the Sentry UI.

[cleptric]

We'll update the docs, we do not support these types of schedules in Sentry.

[rodolfoBee]

Any plans to support it in the future?

[cleptric]

This is a question we need to ask the Cron's team cc @gaprl

[gaprl]

This is a question we need to ask the Cron's team cc @gaprl

Hey @cleptric we do support the */5 9-18 * * * expression, the only crontab expression we don't support are six-field ones (that includes seconds).

[stayallive]

We've identified that the problem is also that Laravel currently doesn't expose the information for us to use, so we are unable to know what the ->between schedule is.

If you are curious that is because Laravel uses a closure to "skip" the execution, so a cron with a between schedule is executed in their normal schedule but skipped by a closure outside the range defined in the between call. There are no properties on the event where we can extract that information from to properly define a cron schedule. See: https://github.com/laravel/framework/blob/484e9c2c78637e3484681d7569a0e3f878dcd594/src/Illuminate/Console/Scheduling/ManagesFrequencies.php#L23-L71

[cleptric]

We clarified our docs in getsentry/sentry-docs#8643

Tasks that use Laravel's between, unlessBetween, when and skip methods are currently not supported.
For the best results, we recommend using Laravel's cron method to define your schedule's frequency.