Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling SSL Verify Peer #858

Closed
Davpyu opened this issue Mar 5, 2024 · 2 comments
Closed

Disabling SSL Verify Peer #858

Davpyu opened this issue Mar 5, 2024 · 2 comments
Assignees

Comments

@Davpyu
Copy link

Davpyu commented Mar 5, 2024

How do you use Sentry?

Self-hosted / on-premises

SDK version

4.2.0

Steps to reproduce

Hello, i want to ask about how to disable ssl_verify_peer?

  1. I tried putting this value on config/sentry.php
    'http_ssl_verify_peer' => false,
  2. and then i add this line on Sentry\Laravel\Console\TestCommand to check if its getting the config. It does giving me the correct config
  3. after that i add this on Sentry\Laravel\Console\TestCommand to check if its still showing the same config
  4. hmm, thats odd. Why its suddenly change? I decide to check on Sentry\ClientBuilder if its changing on that class. It does not change here, so why its suddenly change on number 3?

Expected result

http_ssl_verify_peer should be changing when configure on config/sentry.php

Actual result

For Number 2:
Screenshot 2024-03-05 143211
For Number 3:
Screenshot 2024-03-05 143636
For Number 4:
Screenshot 2024-03-05 144212

@stayallive
Copy link
Collaborator

The php artisan sentry:test uses it's own options and ignores most user-defined options.

See:

$clientBuilder = ClientBuilder::create([
'dsn' => $dsn,
'release' => $laravelClient === null ? null : $laravelClient->getOptions()->getRelease(),
'environment' => $laravelClient === null ? null : $laravelClient->getOptions()->getEnvironment(),
'traces_sample_rate' => 1.0,
]);

So this is why the http_ssl_verify_peer is not picked up when running php artisan sentry:test.

That being said, I think we should not ignore any transport options so I've opened #859 to resolve that oversight and that PR should solve the issue you are seeing.

@cleptric
Copy link
Member

cleptric commented Mar 8, 2024

A fix was released in 4.3.0.

@cleptric cleptric closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants