Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building using VS 2019 16.3.1 fails #58

Closed
martinsliwka opened this issue Oct 1, 2019 · 1 comment
Closed

Building using VS 2019 16.3.1 fails #58

martinsliwka opened this issue Oct 1, 2019 · 1 comment

Comments

@martinsliwka
Copy link

sentry-native\gen_windows\crashpad_zlib.vcxproj defines macro __clang__ and compilation fails with lots of similar errors

1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.23.28105\include\vcruntime_string.h(18,1): error C2059: syntax error: '['

because function declarations in vcruntime_string.h are prefaced by _NODISCARD macro which, for __clang__, is expands to [[nodiscard]]
@martinsliwka martinsliwka changed the title Build using VS 2019 16.3.1 fails Building using VS 2019 16.3.1 fails Oct 1, 2019
@jan-auer
Copy link
Member

Fixed with 0.1.1. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jan-auer @martinsliwka