Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify php_uname function availability before calling EnvironmentIntegration.setOsContext() #1243

Closed
giilby opened this issue Sep 24, 2021 · 2 comments
Milestone

Comments

@giilby
Copy link
Contributor

giilby commented Sep 24, 2021

Similarly to #985, I'm using sentry-php (via wp-sentry) with a WordPress site hosted on Flywheel. Unfortunately, wp-sentry doesn't currently provide a way to properly override the default integrations set up by sentry-php. Looking at the changes made in #1072, it seems like a straightforward way to remedy this issue would be to wrap EnvironmentIntegration:31 with a check to see if the php_uname function is available. Is there any reason not to do this? I'm happy to submit a PR with the change if it makes sense. Thanks!

@giilby giilby changed the title Check php_uname function availability before calling EnvironmentIntegration.setOsContext() Verify php_uname function availability before calling EnvironmentIntegration.setOsContext() Sep 24, 2021
@ste93cry
Copy link
Collaborator

As I mentioned in the past, I think this is the classic case of "security through obscurity" and by wrapping the function calls with a function_exist check may open the door to end up like WordPress that checks that all functions exist. Anyway, I would happily accept a PR if you want to propose the change 😄

@ste93cry
Copy link
Collaborator

ste93cry commented Oct 4, 2021

The fix has been released in version 3.3.3

@ste93cry ste93cry closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants