Use content-length header in ASGI instead of reading request body #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonpirker
force-pushed
the
antonpirker/1646-asgi-request-body
branch
from
463599f
to
70723b9
Compare
antonpirker
commented
Oct 3, 2022
|
can you make the PR title more specific? something like
This is what goes into the changelog and right now our changelogs are not very informative. |
sl0thentr0py
requested changes
Oct 3, 2022
antonpirker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did read the whole request body to figuring out the size of the content. This is not optimal at all. Now we read the "content-length" request header and if this header is not there, we just do not touch the request body (because in ASGI the request body is a stream and if it is consumed it can not be accessed again.)
Fixes #1646
Fixes #1631
Fixes #1595
Fixes #1573