add span for response rendering #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response rendering can be a source of slow performance in Django. This change adds a span to track this span
sl0thentr0py
requested changes
Jan 3, 2023
There was a problem hiding this comment.
thx for the feature @chdsbd !
just some nitpicking for naming consistency with the existing code/conventions
sbdchd
added a commit
to recipeyak/recipeyak
that referenced
this pull request
Apr 24, 2023
should include getsentry/sentry-python#1818 so that we get better tracing support for things like the .ical endpoint
kodiakhq bot
pushed a commit
to recipeyak/recipeyak
that referenced
this pull request
Apr 24, 2023
Should include getsentry/sentry-python#1818 which should hopefully fix the tracing for the `.ical` endpoint <img width="912" alt="image" src="https://user-images.githubusercontent.com/7340772/233876484-1c479afd-04fd-4c10-8abd-79ae0c000abb.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response rendering can be a source of slow performance in Django, especially with Django rest framework and serializers. This change adds a span to track this.
related: #1250