fix(profiling): Default in_app decision to None #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the SDK marks all frames as in_app when it can't find any in_app frames. As we try to move some of this detection server side, we still want to allow the end user to overwrite the decision client side. So we'll leave in_app as `None` to indicate the server should decide of the frame is in_app.
Zylphrex
changed the title
sl0thentr0py
approved these changes
Jan 23, 2023
Zylphrex
deleted the
txiao/fix/default-in-app-decision-to-none-for-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SDK marks all frames as in_app when it can't find any in_app frames. As we try to move some of this detection server side, we still want to allow the end user to overwrite the decision client side. So we'll leave in_app as
Noneto indicate the server should decide of the frame is in_app.