Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pii): Sanitize URLs in Span description and breadcrumbs #1876

Merged
merged 31 commits into from Feb 16, 2023
Merged

feat(pii): Sanitize URLs in Span description and breadcrumbs #1876

merged 31 commits into from Feb 16, 2023

Conversation

antonpirker
Copy link
Member

Fixes #1742

@antonpirker
Strip sensitive data from URLs. refs 1742
74e9c08
@antonpirker
Better function name
71d5e4a
@antonpirker
Check send_default_pii before sanitizing url.
743c3d1
@antonpirker
Ignore typing on named tuples
0560891
@antonpirker
Make it run in Python 2
5d25063
@antonpirker
Merge branch 'master' into antonpirker/1742-remove-sensitive-data-fro…
a16b5ab 
…m-urls
@antonpirker
Split url into url, query and fragment
63df676
@antonpirker
Some type fixes
4db535f
@antonpirker
Preventing circular import
ce56e93
@antonpirker
Fixed some tests
e418033
@antonpirker
Make url a string to fix tests
5bbd781
@antonpirker
Fixing httpx tests again
fcbd8d7
@antonpirker
Fixing tests
2bd870c
@antonpirker
Fix tests for old Python versions
72a4675
@antonpirker
Merge branch 'master' into antonpirker/1742-remove-sensitive-data-fro…
e8e05e9 
…m-urls
@antonpirker
Fix tests with fragments in old Python versions
1639cc4
@antonpirker
Merge branch 'antonpirker/1742-remove-sensitive-data-from-urls' of gi…
11b9bf2 
…thub.com:getsentry/sentry-python into antonpirker/1742-remove-sensitive-data-from-urls
@antonpirker
Merge branch 'master' into antonpirker/1742-remove-sensitive-data-fro…
c67be60 
…m-urls
@antonpirker
Fixed utf8 chars in Python 2.7
90eb4db
@antonpirker
Cleanup
9215f45
@antonpirker
Merge branch 'master' into antonpirker/1742-remove-sensitive-data-fro…
68dda23 
…m-urls
@antonpirker antonpirker marked this pull request as ready for review January 31, 2023 13:04
@antonpirker antonpirker requested review from sl0thentr0py and removed request for sl0thentr0py February 3, 2023 13:23
@antonpirker antonpirker changed the title Sanitize URLs in Span description and breadcrumbs feat(pii): Sanitize URLs in Span description and breadcrumbs Feb 6, 2023
sl0thentr0py
sl0thentr0py requested changes Feb 9, 2023
View reviewed changes
sentry_sdk/utils.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/stdlib.py Show resolved Hide resolved
@antonpirker antonpirker enabled auto-merge (squash) February 16, 2023 07:05
@antonpirker antonpirker merged commit ba1286e into master Feb 16, 2023
@antonpirker antonpirker deleted the antonpirker/1742-remove-sensitive-data-from-urls branch February 16, 2023 07:08
@aldenquimby aldenquimby mentioned this pull request Feb 16, 2023
Closed
2 tasks
@jamescrosswell jamescrosswell mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleptric cleptric cleptric left review comments

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitize URLs in Span description and breadcrumbs
3 participants
@antonpirker @sl0thentr0py @cleptric