Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django caching span fixes #2086

Merged
merged 5 commits into from
May 8, 2023
Merged

Django caching span fixes #2086

merged 5 commits into from
May 8, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 8, 2023 •
edited

  • Fix problem when the cache key is given with kwargs (instead of positional args)
  • Using the more specific cache.get_item span op because we only patch the getting cache functions.

Fixes #2085

sentrivana
sentrivana approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, else LGTM

sentry_sdk/integrations/django/caching.py Outdated Show resolved Hide resolved
@antonpirker antonpirker enabled auto-merge (squash) May 8, 2023 10:04
@antonpirker antonpirker merged commit a5f8d37 into master May 8, 2023
234 of 236 checks passed
@antonpirker antonpirker deleted the antonpirker/caching-span-fixes branch May 8, 2023 12:12
@antonpirker antonpirker self-assigned this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DjangoCache IndexError raised when using keywords approach
2 participants
@antonpirker @sentrivana