Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Duration in Celery Beat tasks monitoring #2087

Merged
merged 6 commits into from
May 8, 2023

Conversation

antonpirker
Copy link
Member

We can not use a perf_counter when dealing with duration's of Celery tasks, because the start of a Celery tasks and the finish are recorded in different processes.

Start happens in the Celery Beat process, the end in the Celery Worker process.

Fixes #2078

@antonpirker antonpirker self-assigned this May 8, 2023
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some typos, looks good otherwise 🚀

sentry_sdk/integrations/celery.py Outdated Show resolved Hide resolved
Co-authored-by: Ivana Kellyerova <131587164+sentrivana@users.noreply.github.com>
@antonpirker antonpirker enabled auto-merge (squash) May 8, 2023 10:05
@antonpirker antonpirker merged commit 1c35d48 into master May 8, 2023
235 of 236 checks passed
@antonpirker antonpirker deleted the antonpirker/2078-duration-in-celery-monitoring branch May 8, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Duration for Celery Monitoring
2 participants