Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Celery headers for Beat auto-instrumentation #2102

Merged
merged 8 commits into from
May 15, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 11, 2023

Without this only the "IN_PROGRESS" check ins for Celery Beat tasks are sent to Sentry but the "OK" or "ERROR" events are ignored, because the hooks do not have the information about what Cron monitor they are related to.

Fixes #2104

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a typo, otherwise lgtm!

tests/integrations/celery/test_celery.py Outdated Show resolved Hide resolved
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
@antonpirker antonpirker merged commit f8f53b8 into master May 15, 2023
244 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-crons-header-propagation branch May 15, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron checkins are not sent for celery beat tasks
2 participants