Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert partial hack, but keep docs #2224

Merged
merged 2 commits into from Jul 4, 2023
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 4, 2023

The partial hack enabled us to have nicer sphinx docs, but broke any autocompletion in PyCharm.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sentrivana sentrivana merged commit d8a81a9 into master Jul 4, 2023
244 checks passed
@sentrivana sentrivana deleted the ivana/remove-kwargs-hack branch July 4, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants