Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(crons): Add information to short-interval cron error message #2246

Merged

Conversation

lobsterkatie
Copy link
Member

This adds both the name of the problematic monitor and a suggestion of how to fix the problem to the error message about crons with < 1 min intervals.

@lobsterkatie lobsterkatie force-pushed the kmclb-add-monitor-name-to-short-interval-cron-error branch 5 times, most recently from 00afab9 to c19146f Compare July 12, 2023 18:12
@lobsterkatie lobsterkatie force-pushed the kmclb-add-monitor-name-to-short-interval-cron-error branch from c19146f to 1e81de1 Compare July 13, 2023 16:58
@lobsterkatie
Copy link
Member Author

@antonpirker - Any theories about why just the one gevent test suite is failing? I took a look and it doesn't seem to be at all related to this change, though maybe there's a connection I'm missing. Would you mind taking a look, please?

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @lobsterkatie !

lgtm

@antonpirker
Copy link
Member

btw @lobsterkatie the failing gevent tests where just a bit flaky

@antonpirker antonpirker merged commit eed56e1 into master Jul 20, 2023
246 checks passed
@antonpirker antonpirker deleted the kmclb-add-monitor-name-to-short-interval-cron-error branch July 20, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants