Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure each task that is started by Celery Beat has its own trace. #2249

Merged
merged 2 commits into from Jul 13, 2023
Merged

Make sure each task that is started by Celery Beat has its own trace. #2249

merged 2 commits into from Jul 13, 2023

Conversation

antonpirker
Copy link
Member

When tasks are started by Celery Beat they should not inherit the trace from the starting code (which is Celery Beat) but get their own trace.

@antonpirker antonpirker marked this pull request as ready for review July 13, 2023 09:42
sentrivana
sentrivana approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would move the debug log but otherwise lgtm!

@antonpirker antonpirker enabled auto-merge (squash) July 13, 2023 10:00
@antonpirker antonpirker merged commit d586149 into master Jul 13, 2023
243 of 244 checks passed
@antonpirker antonpirker deleted the antonpirker/separate-traces-for-tasks-started-by-celery-beat branch July 13, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonpirker @sentrivana