Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always sample checkin regardless of sample_rate #2279

Merged
merged 4 commits into from Jul 31, 2023
Merged

Always sample checkin regardless of sample_rate #2279

merged 4 commits into from Jul 31, 2023

Conversation

szokeasaurusrex
Copy link
Member

Fixes #2268

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 31, 2023 08:25
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 31, 2023 08:26
sentrivana
sentrivana approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@szokeasaurusrex szokeasaurusrex merged commit 69866be into master Jul 31, 2023
245 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/always-sample-cron-checkin branch July 31, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sample_rate option affecting crons checkin events
2 participants
@szokeasaurusrex @sentrivana