New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Shift flushing by up to a rollup window #2396

Merged

mitsuhiko merged 2 commits into master from feature/shift-flushing

Sep 28, 2023

Member

mitsuhiko commented Sep 28, 2023 •

edited

Modelled after the similar behavior in Relay. However unlike shifting on a per-project basis, we shift randomly per application start.

Refs relay https://github.com/getsentry/relay/blob/c8601c825402ee1eaf015c6ce4b7aca715627cf5/relay-metrics/src/aggregation.rs#L385-L400


          feat(metrics): Shift flushing by up to a rollup window

f272951

mitsuhiko requested a review from jan-auer

September 28, 2023 08:53


          fix: incorrect const

ac5dd68

jan-auer approved these changes

View reviewed changes

mitsuhiko merged commit f35adf3 into master

262 of 263 checks passed

mitsuhiko deleted the feature/shift-flushing branch

September 28, 2023 11:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment