Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Make a consistent noop flush behavior #2428

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat(metrics): Make a consistent noop flush behavior #2428

merged 2 commits into from
Oct 10, 2023

Conversation

mitsuhiko
Copy link
Member

This simplifies the noop behavior for the recursion detection:

  • background thread now always sets in_metrics
  • force flush now marks flush as noop which sets in_metrics

In either case _flush is called and is then protected if it were to call into add or flush.

@mitsuhiko mitsuhiko marked this pull request as ready for review October 10, 2023 10:28
@mitsuhiko mitsuhiko mentioned this pull request Oct 10, 2023
Merged
@mitsuhiko mitsuhiko enabled auto-merge (squash) October 10, 2023 10:52
@mitsuhiko mitsuhiko merged commit 1b445c6 into master Oct 10, 2023
278 of 279 checks passed
@mitsuhiko mitsuhiko deleted the feature/make-flush-noop branch October 10, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitsuhiko @iambriccardo