Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django custom 404 transaction do not have a transaction source #2520

Open
antonpirker opened this issue Nov 21, 2023 · 0 comments · May be fixed by #2529
Open

Django custom 404 transaction do not have a transaction source #2520

antonpirker opened this issue Nov 21, 2023 · 0 comments · May be fixed by #2529
Assignees
Labels
Integration: Django Type: Bug Something isn't working

Comments

@antonpirker
Copy link
Member

antonpirker commented Nov 21, 2023

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.35.0

Steps to Reproduce

If you look at the code here we are setting the transaction, but not the transaction source:

if isinstance(handler, string_types):
scope.transaction = handler
else:
scope.transaction = transaction_from_function(
getattr(handler, "view_class", handler)
)

Add the transaction with something like this:
https://github.com/getsentry/sentry-python/pull/2519/files

@antonpirker antonpirker self-assigned this Nov 21, 2023
@antonpirker antonpirker added Type: Bug Something isn't working Integration: Django labels Nov 21, 2023
@antonpirker antonpirker linked a pull request Nov 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration: Django Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant