Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create transaction for Django "/" redirects #2673

Open
antonpirker opened this issue Jan 24, 2024 · 1 comment
Open

Do not create transaction for Django "/" redirects #2673

antonpirker opened this issue Jan 24, 2024 · 1 comment
Labels

Comments

@antonpirker
Copy link
Member

Problem Statement

Django does redirects from URLs with a trailing "/" to an url containing the "/" (or vice verce, depending on your config) In those cases our Integration does not know the route and creates a transaction with the raw URL. This creates a lot of cardinality.

Solution Brainstorm

Do not create transaction for those framework redirects, because there is not much happening in them and they just create noise.

@antonpirker antonpirker added this to the Django update milestone Jan 24, 2024
@antonpirker antonpirker removed this from the Django update milestone Jun 20, 2024
@szokeasaurusrex
Copy link
Member

I spent some time investigating this today, but will move onto other things because it seems like the solution is non-trivial. Specifically, we need to come up with a reliable way to detect when we have a Django redirect to add/remove a trailing slash, and we need to ensure the changes do not affect other WSGI frameworks (transactions are created in the WSGI integration).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants