Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #2686

Closed
sentrivana opened this issue Jan 29, 2024 · 1 comment
Closed

Fix flaky test #2686

sentrivana opened this issue Jan 29, 2024 · 1 comment
Labels
Component: CI Dealing with Github Actions Component: Tests Dealing with tests Type: Bug Something isn't working

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Jan 29, 2024

Version

1.39.2

Steps to Reproduce

Run the common test suite in CI. Chances are the cloud_resource_context test_setup_once test will report a failure.

Expected Result

The test is not flaky.

Actual Result

=================================== FAILURES ===================================
_____________ test_setup_once[-cloud_resource_context7-False-True] _____________
tests/integrations/cloud_resource_context/test_cloud_resource_context.py:410: in test_setup_once
    fake_warning.assert_not_called()
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/unittest/mock.py:874: in assert_not_called
    raise AssertionError(msg)
E   AssertionError: Expected 'warning' to not have been called. Called 2 times.
E   Calls: [call('Can not create a child span for %s. Please start a Sentry transaction before calling this function.', 'time.sleep'),
E    call('Can not create a child span for %s. Please start a Sentry transaction before calling this function.', 'time.sleep')].
@sentrivana sentrivana added Type: Bug Something isn't working Component: Tests Dealing with tests Component: CI Dealing with Github Actions labels Jan 29, 2024
@sentrivana
Copy link
Contributor Author

I haven't seen this happen in some time, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CI Dealing with Github Actions Component: Tests Dealing with tests Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant