Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction discarded debug messages #3002

Merged
merged 3 commits into from Apr 25, 2024
Merged

Fix transaction discarded debug messages #3002

merged 3 commits into from Apr 25, 2024

Conversation

szokeasaurusrex
Copy link
Member

Fixes #3000

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-sampled-debug-message branch 2 times, most recently from e79e16d to a090a5c Compare April 22, 2024 16:00
@szokeasaurusrex szokeasaurusrex linked an issue Apr 22, 2024 that may be closed by this pull request
Improve debug message when dropping transaction #3000
Closed
antonpirker
antonpirker approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

Base automatically changed from sentry-sdk-2.0 to master April 25, 2024 09:13
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-sampled-debug-message branch 2 times, most recently from f8586eb to d0fc544 Compare April 25, 2024 13:12
@szokeasaurusrex
docs(tracing): Delete inaccurate comment
bda9deb 
`sampled` being set to `False` is not the only reason why the `_span_recorder` might be `None`. Another explanation is that the transaction was not started via `start_transaction`.
@szokeasaurusrex
fix(tracing): Correct discarded transaction debug message
5aa7c9b 
Transactions that are discarded because `_span_recorder` is `None` can also be discarded because they were not started with `sentry_sdk.start_transaction`. This change updates the debug message accordingly.

Fixes GH-3000
@szokeasaurusrex
test(tracing): Add tests for discarded transaction debug messages
534a301
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/transaction-sampled-debug-message branch from d0fc544 to 534a301 Compare April 25, 2024 13:26
@szokeasaurusrex szokeasaurusrex merged commit 534a301 into master Apr 25, 2024
111 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/transaction-sampled-debug-message branch April 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve debug message when dropping transaction
2 participants
@szokeasaurusrex @antonpirker