Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include OTel in type checks #3148

Closed
sentrivana opened this issue Jun 10, 2024 · 0 comments · Fixed by #3168
Closed

Include OTel in type checks #3148

sentrivana opened this issue Jun 10, 2024 · 0 comments · Fixed by #3168

Comments

@sentrivana
Copy link
Contributor

sentrivana commented Jun 10, 2024

Problem Statement

Our lint workflow doesn't install any opentelemetry packages so the span processor, propagator etc. are essentially excluded from any type checks.

Solution Brainstorm

Now that we're starting to rely on OTel more we should add the necessary OTel packages to linter-requirements.txt, remove the type: ignores in otel files and fix the mypy fallout.

@sentrivana sentrivana added the Enhancement New feature or request label Jun 11, 2024
@sentrivana sentrivana linked a pull request Jun 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant