Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry-resque does not have resque as a dependency #1502

Closed
mensfeld opened this issue Jul 8, 2021 · 3 comments · Fixed by #1503
Closed

sentry-resque does not have resque as a dependency #1502

mensfeld opened this issue Jul 8, 2021 · 3 comments · Fixed by #1503
Assignees
Projects
Milestone

Comments

@mensfeld
Copy link

mensfeld commented Jul 8, 2021

Describe the bug

cannot load such file -- resque

To Reproduce

gem install sentry-resque --no-doc
ruby -e 'require "sentry-resque"'

Expected behavior

I would expect it not to fail.

Actual behavior

.rbenv/versions/2.7.3/lib/ruby/site_ruby/2.7.0/rubygems/core_ext/kernel_require.rb:148:in `require': cannot load such file -- resque (LoadError)

Environment

  • Ruby Version: 2.7.3
  • SDK Version: NA
  • Integration Versions (if any): None
  • e.g. Rails 6.0, Sidekiq 6.1.2

Sentry Config

None

@st0012
Copy link
Collaborator

st0012 commented Jul 8, 2021

Yeah I think it's better to declare the dependency, thanks. But just curious, why did you require sentry-resque without having resque installed?

@mensfeld
Copy link
Author

mensfeld commented Jul 8, 2021

I'm a security researcher and creator of https://diffend.io - we use a lot of automation to check security and quality of packages and it popped out :)

@st0012
Copy link
Collaborator

st0012 commented Jul 8, 2021

@mensfeld I see. I've added a PR to fix it. Thanks again 👍

@st0012 st0012 added this to To do in 4.x via automation Jul 8, 2021
@st0012 st0012 added this to the 4.7.0 milestone Jul 8, 2021
4.x automation moved this from To do to Done Jul 9, 2021
@st0012 st0012 modified the milestones: 4.7.0, 4.6.2 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.x
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants