Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Failure JSON gem with 'ruby-head' #947

Closed
ksylvest opened this issue Jan 14, 2020 · 2 comments
Closed

Fix CI Failure JSON gem with 'ruby-head' #947

ksylvest opened this issue Jan 14, 2020 · 2 comments

Comments

@ksylvest
Copy link
Contributor

Ruby JSON appears to have changed parsing of errors between v2.6 and v2.7. For example - when running:

require 'json'

data = {}
data['cycle'] = data
JSON.dump(data)

With Ruby v2.6.5

This raises a SystemStackError.

With Ruby v2.7.0

This causes fatal (machine stack overflow in critical region)

This is causing Travis CI to fail:

https://travis-ci.org/getsentry/raven-ruby/jobs/636721290?utm_medium=notification&utm_source=github_status

https://github.com/getsentry/raven-ruby/blob/master/spec/raven/json_spec.rb#L75

@ksylvest ksylvest changed the title Fix CI Failure JSON gem Fix CI Failure JSON gem with 'ruby-head' Jan 14, 2020
@ksylvest
Copy link
Contributor Author

Note: confirmed this isn't a ruby version issue - but actually a JSON gem version issue:

With json v2.1.0

This raises a SystemStackError.

With json v2.3.0

This causes fatal (machine stack overflow in critical region)

  • Ruby 2.7.0 has 2.3.0 as default
  • Ruby 2.6.5 has 2.1.0 as default

@ksylvest
Copy link
Contributor Author

ksylvest commented Mar 2, 2020

@ksylvest ksylvest closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant