Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry Wizard fails to modify Bundle React Native and images #572

Open
thomasttvo opened this issue May 25, 2024 · 1 comment
Open

Sentry Wizard fails to modify Bundle React Native and images #572

thomasttvo opened this issue May 25, 2024 · 1 comment

Comments

@thomasttvo
Copy link

thomasttvo commented May 25, 2024

Environment

Due to the older versions of Sentry not working with Hermes, we needed to modify Bundle React Native and images to support hermes, at which time we removed $REACT_NATIVE_XCODE from the build phase. The wizard for the latest version just performs a string replacement without checking whether the $REACT_NATIVE_XCODE is there, which reports false positive.

Steps to Reproduce

Run npx @sentry/wizard@latest -s -i reactNative

Expected Result

The wizard alerts us that it's unable to fix this build phase. It does that for metro config but not for Bundle React Native and images

Actual Result

The wizard reported that it was able to fix the build phase just fine ✅ , which is wrong

@Lms24
Copy link
Member

Lms24 commented May 27, 2024

Hey @thomasttvo thanks for writing in! Sounds like a reasonable expectation to me at first glance but I'm not deep enough into RN. Gonna tag @krystofwoldrich - would you mind taking a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants