Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session-local events are not always reliable. #230

Open
dcramer opened this issue Dec 5, 2023 · 2 comments
Open

Session-local events are not always reliable. #230

dcramer opened this issue Dec 5, 2023 · 2 comments
Labels
Type: Enhancement New feature or request

Comments

@dcramer
Copy link
Member

dcramer commented Dec 5, 2023

There are some cases where the local-to-session behavior does not work as desired. This generally is when the Sentry instrumentation is misconfigured or the SDK itself has incorrect behavior.

An example of this being an upstream problem can be seen in Remix:

getsentry/sentry-javascript#9737

We'll use this isue to track this concern and identify improvmeents to the heuristics.

One example improvement we could make is, when the behavior is unreliable (a flag maybe?), bias towards events that are seen only within a period of time since the session became active. We still have an upper bound issue there, but possibly a similar check could exist for that.

Another issue we might consider making is a flag to disable this feature. We might consider this feature experimental (albeit desired), so keeping it on by default would still be the goal.

Refs #188

@MisterJimson
Copy link

Just some feedback from my experience using Spotlight for the first time.

We have a mono repo with a backend and 2 frontend projects. When I open the overlay in the frontend, all of the backend errors and traces are shown as from a different session, even when initiated from the frontend session I am viewing.

The backend correctly shows spans as part of the trace, so it does know the two are related.

@dcramer
Copy link
Member Author

dcramer commented Feb 12, 2024

@MisterJimson they have a diff trace ID tho, yeah?

The issue is we're looking for frontend-initiated traces. Its possible the instrumentation is bad here, or we have a bug.

Whats the stack? Specifically whats the frontend SDK and whats the backend SDK that should be interacting with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants