-
-
Notifications
You must be signed in to change notification settings - Fork 44
/
minidump.rs
217 lines (173 loc) · 7.29 KB
/
minidump.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
use axum::extract;
use axum::http::StatusCode;
use axum::response::Json;
use symbolic::common::ByteView;
use tokio::fs::File;
use crate::endpoints::symbolicate::SymbolicationRequestQueryParams;
use crate::metric;
use crate::service::{RequestOptions, RequestService, SymbolicationResponse};
use crate::utils::sentry::ConfigureScope;
use super::multipart::{read_multipart_data, stream_multipart_file};
use super::ResponseError;
pub async fn handle_minidump_request(
extract::State(service): extract::State<RequestService>,
extract::Query(params): extract::Query<SymbolicationRequestQueryParams>,
mut multipart: extract::Multipart,
) -> Result<Json<SymbolicationResponse>, ResponseError> {
sentry::start_session();
params.configure_scope();
let mut minidump = None;
let mut sources = service.config().default_sources();
let mut options = RequestOptions::default();
while let Some(field) = multipart.next_field().await? {
match field.name() {
Some("upload_file_minidump") => {
let mut minidump_file = tempfile::Builder::new();
minidump_file.prefix("minidump").suffix(".dmp");
let minidump_file = if let Some(tmp_dir) = service.config().cache_dir("tmp") {
minidump_file.tempfile_in(tmp_dir)
} else {
minidump_file.tempfile()
}?;
let (file, temp_path) = minidump_file.into_parts();
let mut file = File::from_std(file);
stream_multipart_file(field, &mut file).await?;
minidump = Some(temp_path)
}
Some("sources") => {
let data = read_multipart_data(field, 1024 * 1024).await?; // 1Mb
sources = serde_json::from_slice(&data)?;
}
Some("options") => {
let data = read_multipart_data(field, 1024 * 1024).await?; // 1Mb
options = serde_json::from_slice(&data)?;
}
_ => (), // Always ignore unknown fields.
}
}
let minidump_file = minidump.ok_or((StatusCode::BAD_REQUEST, "missing minidump"))?;
// check if the minidump starts with multipart form data and discard it if so
let minidump_path = minidump_file.to_path_buf();
let minidump = ByteView::open(minidump_path).unwrap_or_else(|_| ByteView::from_slice(b""));
if minidump.starts_with(b"--") {
metric!(counter("symbolication.minidump.multipart_form_data") += 1);
return Err((
StatusCode::BAD_REQUEST,
"minidump contains multipart form data",
)
.into());
}
let request_id = service.process_minidump(params.scope, minidump_file, sources, options)?;
match service.get_response(request_id, params.timeout).await {
Some(response) => Ok(Json(response)),
None => Err("symbolication request did not start".into()),
}
}
#[cfg(test)]
mod tests {
use reqwest::{multipart, Client, StatusCode};
use crate::service::SymbolicationResponse;
use crate::test;
#[tokio::test]
async fn test_basic() {
test::setup();
let server = test::server_with_default_service();
let file_contents = test::read_fixture("windows.dmp");
let file_part = multipart::Part::bytes(file_contents).file_name("windows.dmp");
let form = multipart::Form::new()
.part("upload_file_minidump", file_part)
.text("sources", "[]");
let response = Client::new()
.post(server.url("/minidump"))
.multipart(form)
.send()
.await
.unwrap();
assert_eq!(response.status(), StatusCode::OK);
let response: SymbolicationResponse = response.json().await.unwrap();
test::assert_snapshot!(response);
}
#[tokio::test]
async fn test_integration_microsoft() {
test::setup();
let server = test::server_with_default_service();
let source = test::microsoft_symsrv();
let file_contents = test::read_fixture("windows.dmp");
let file_part = multipart::Part::bytes(file_contents).file_name("windows.dmp");
let form = multipart::Form::new()
.part("upload_file_minidump", file_part)
.text("sources", serde_json::to_string(&vec![source]).unwrap())
.text("options", r#"{"dif_candidates":true}"#);
let response = Client::new()
.post(server.url("/minidump"))
.multipart(form)
.send()
.await
.unwrap();
assert_eq!(response.status(), StatusCode::OK);
let response: SymbolicationResponse = response.json().await.unwrap();
test::assert_snapshot!(response);
}
#[tokio::test]
async fn test_unknown_field() {
test::setup();
let server = test::server_with_default_service();
let file_contents = test::read_fixture("windows.dmp");
let file_part = multipart::Part::bytes(file_contents).file_name("windows.dmp");
let form = multipart::Form::new()
.part("upload_file_minidump", file_part)
.text("sources", "[]")
.text("unknown", "value");
let response = Client::new()
.post(server.url("/minidump"))
.multipart(form)
.send()
.await
.unwrap();
assert_eq!(response.status(), StatusCode::OK);
}
#[tokio::test]
async fn test_body_limit() {
test::setup();
let server = test::server_with_default_service();
let len = 96 * 1024 * 1024;
let mut buf = vec![b'.'; len];
buf[0..4].copy_from_slice(b"MDMP");
let file_part =
multipart::Part::stream_with_length(buf, len as u64).file_name("minidump.dmp");
let form = multipart::Form::new()
.part("upload_file_minidump", file_part)
.text("sources", "[]");
let response = Client::new()
.post(server.url("/minidump"))
.multipart(form)
.send()
.await
.unwrap();
assert_eq!(response.status(), StatusCode::OK);
// well, the minidump is obviously invalid :-)
let body = response.text().await.unwrap();
assert_eq!(
&body,
"{\"status\":\"failed\",\"message\":\"Minidump version mismatch\"}"
);
let len = 112 * 1024 * 1024;
let mut buf = vec![b'.'; len];
buf[0..4].copy_from_slice(b"MDMP");
let file_part =
multipart::Part::stream_with_length(buf, len as u64).file_name("minidump.dmp");
let form = multipart::Form::new()
.part("upload_file_minidump", file_part)
.text("sources", "[]");
let response = Client::new()
.post(server.url("/minidump"))
.multipart(form)
.send()
.await;
// FIXME(swatinem): it is a bit unclear which error we get exactly, and from which internal
// parts. This can give us an internal server error or a connection reset depending on OS
// right now. Ideally, it should give us a `PAYLOAD_TOO_LARGE`, but that might require some
// more work inside of `axum`, see <https://github.com/tokio-rs/axum/issues/1623>.
assert!(response.is_err() || !response.unwrap().status().is_success());
}
}