Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableTracing option to SDKs #21

Closed
7 tasks done
smeubank opened this issue Feb 6, 2023 · 4 comments
Closed
7 tasks done

Add enableTracing option to SDKs #21

smeubank opened this issue Feb 6, 2023 · 4 comments

Comments

@smeubank
Copy link
Member

smeubank commented Feb 6, 2023

Context: getsentry/develop#769

A new simplified options for configuring to turn tracing & performance on should be added to all SDKs. For each SDK the default sample rate should be agreed upon.

Docs do not need to be updated yet, nor the onboarding wizard. This can wait until the top level options are added to a number of SDKs and we decide if we want to configure the default onboarding experience, for all new users.

Web:

Mobile meta issue.

@smeubank
Copy link
Member Author

smeubank commented Feb 6, 2023

@cleptric it was already added to the Go SDK, but is it a breaking change there? It is actually required due to platform specifics of Go. Is that correct? No way around that?

@cleptric
Copy link
Member

cleptric commented Feb 6, 2023

@smeubank It was a none-breaking change in terms of that code still compiles happily, but a breaking change in terms of that you need to set it to enable performance monitoring. If you set it, a TracesSampleRate/TracesSampler is required as well, these two options go hand in hand.
I would not change this for the time being, as we have to come up with a better plan to work around Go's null values anyways, so for the moment it's good enough imo.

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Feb 7, 2023

What is the expected behavior of the flag?

enableTracing=true -> use default tracesSampleRate=1

enableTracing=false and tracesSampleRate=0.5 -> what should happen? will enableTracing have higher priority?

@cleptric
Copy link
Member

cleptric commented Feb 7, 2023

@krystofwoldrich Have a look at getsentry/develop#769 and getsentry/develop#801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants