[td] log error instead of throwing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In clients whom intentionally decide to not initialise TelemetryDeck (for example on non-produciton environments, unit tests, etc), they would have to add a wrapper around all the interactions in order to avoid a situation which would throw 500s when used in requests. This wasn't intentional, and the error didn't seem relevant enough to warrant a reaction by the client. If you've not registered - it's probably for a reason. So we've replaced it with a log instead. May consider making it a one-off, will consider options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clients whom intentionally decide to not initialise TelemetryDeck (for example on non-produciton environments, unit tests, etc), they would have to add a wrapper around all the interactions in order to avoid a situation which would throw 500s when used in requests.
This wasn't intentional, and the error didn't seem relevant enough to warrant a reaction by the client. If you've not registered - it's probably for a reason.
So we've replaced it with a log instead. May consider making it a one-off, will consider options.