Swagger from file #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,7 +120,8 @@ def _extract_array_defs(source): | |||
| return defs | |||
|
|
|||
|
|
|||
| def swagger(app, prefix=None, process_doc=_sanitize, template=None): | |||
| def swagger(app, prefix=None, process_doc=_sanitize, | |||
| from_file_keyword='swagger_from_file', template=None): | |||
There was a problem hiding this comment.
I would prefer from_file_keyword to be default None in which case skip the find_from_file process
|
Otherwise looks good and thanks for contributing! |
|
Thanks for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a proposal to decode a special line in a docstring
swagger_from_file: path.I think it could be useful sometimes to take the yaml swagger spec out of the docstring:
In the pull request you'll find besides flask_swagger.py a modified example and README.md
Please criticize as needed.
Thanks.