Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bug: SendButton component receives an improper prop 'title' #134

Closed
fbartho opened this issue Feb 6, 2020 · 3 comments
Closed

Minor Bug: SendButton component receives an improper prop 'title' #134

fbartho opened this issue Feb 6, 2020 · 3 comments
Assignees
Labels
Bug Something isn't working in the SDK

Comments

@fbartho
Copy link
Contributor

fbartho commented Feb 6, 2020

Describe the bug
The SendButtonProps are documented (in TypeScript) as receiving a title, editing, sendMessage()

The the value in the title, appears to be related to a camera image picker however as seen in this screenshot:

Screenshot of the title rendered into our button

Dev environment info (please complete/provide the following information):

  • Package versions:
"stream-chat": "1.3.x",
"stream-chat-react-native": "0.6.5",
  • react-native version
  • Detected on iOS Simulator Version 10.3 (SimulatorApp-880.5 CoreSimulator-681.17.2)

To Reproduce

Render the title parameter passed to the SendButton component that you pass into the MessageInput component

Expected behavior

Expected behavior -- remove the title prop or document what it's for / how its supposed to be used.

I would naively assume that the title should just be "Send" or "Send Message" (but localization is a concern).

Screenshots

Cropped Screenshot Provided Above, Full Screenshot here:
image

@fbartho fbartho added the Bug Something isn't working in the SDK label Feb 6, 2020
@fbartho
Copy link
Contributor Author

fbartho commented Feb 7, 2020

@vishalnarkhede Found the line of code here:

title="Pick an image from camera roll"

@vishalnarkhede
Copy link
Contributor

Hey @fbartho thanks for brining this to our attention. I will fix this in next release :)

@vishalnarkhede
Copy link
Contributor

@fbartho this has been fixed as part of 0.6.6. now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working in the SDK
Projects
None yet
Development

No branches or pull requests

2 participants