Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageSimple component has no ability to set "grow" prop for MessageInput (in message edit mode) #116

Closed
volodymyr-manko opened this issue Dec 31, 2019 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@volodymyr-manko
Copy link

The inability to set false for prop grow for MessageInput component inside MessageSimple component (or configure anyhow MessageInput field size) in message edit mode leads to a situation, when large text (in opened Edit message modal) automatically increases the input field, which moves Emoji picker to top and crops it, so the user can't select preferrable emoji:

{editing && (
          <Modal open={editing} onClose={clearEditingState}>
            <MessageInput
              Input={EditMessageForm}
              message={message}
              clearEditingState={clearEditingState}
              updateMessage={updateMessage}
            />
          </Modal>
        )}

So, could you please add the ability to set additional props for MessageInput inside MessageSimple component, and/or to support the fixed multirow size for MessageInput component (e.g. via prop maxRows)

@jaapbakker88 jaapbakker88 added bug Something isn't working enhancement New feature or request labels Dec 31, 2019
@jaapbakker88
Copy link
Contributor

Hi @volodymyr-manko, will have a look at this in the new year. Just to be clear, you're talking about the edit form that's being used in MessageSimple.

@volodymyr-manko
Copy link
Author

Hi @jaapbakker88, yes I'm talking about edit form that's being used in MessageSimple.

But as for supporting new prop maxRows for MessageInput - I think it'll be good to have the ability to configure it in different parts of a chat, not only in MessageSimple.

@jaapbakker88
Copy link
Contributor

@volodymyr-manko included a prop additionalMessageInputProps on the Message components. I also added maxRows to all the inputs so this is now configurable

it's live right now on 0.7.17

@volodymyr-manko
Copy link
Author

Sounds great, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants