Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal component is also not exported nor typed #135

Closed
damianprzygodzki opened this issue Jan 15, 2020 · 1 comment
Closed

Modal component is also not exported nor typed #135

damianprzygodzki opened this issue Jan 15, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@damianprzygodzki
Copy link

damianprzygodzki commented Jan 15, 2020

I can't use Modal i.e. when i want to customize editing of message...

Guys, this "UI-kit" is pretty useless when you want to use it with typescript. You are using doubled declarations of propTypes (one in components, second in ts files). Maybe its good to make refactor of these or make awareness that ts here is not supported?

@vishalnarkhede
Copy link
Contributor

Hey @damianprzygodzki we will soon update this repo by exporting all the components with their types.

Our next major refactor will publish all the components in typescript itself instead of maintaining separate typescript declaration file.

@vishalnarkhede vishalnarkhede self-assigned this Jan 30, 2020
@vishalnarkhede vishalnarkhede added the bug Something isn't working label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants