Input is too high when chat is presented in UITabBarController

[mpodeszwa]

What did you do?

I present Chat inside UITabBarController

What did you expect to happen?

Input is right above keyboard

What happened instead?

Input is offset from the keyboard (probably by tabbar's height)

Additional context

Device: Iphone 11

I created branch to show the problem:
https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset

[buh]

Thanks! I'll check.

[Spenser]

We are also experiencing this as well

[buh]

Hi guys, it should be fixed in the last release.
Let me know if it still there.

[mpodeszwa]

Hi @buh ,
It's almost fixed :) It works if tab bar is translucent, but if this flag is turned off then problem is still there. I rebased my branch, you can check it out https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset

[buh]

Fixed in the next version 1.4.0.

[mpodeszwa]

Hi @buh ,
I checked out master and unfortunately I don't think it's completely fixed.
This is how chat looks without the tab bar:

And with the tab bar:

I was testing on iPhone 11 Pro Max. I rebased my branch again https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset 😄

[mpodeszwa]

Hi @buh
After fixing #36 this bug reappeared 😭 #36 is now fixed :)

[mpodeszwa]

rebased once more https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset :D

[buh]

That's weird. Thanks! I'll check

[buh]

@mpodeszwa Do you mean #36 was fixed and #28 was not?

[mpodeszwa]

I thought in 1.5.0 #28 was fine and #36 appeared and now in 1.5.1 it's the opposite. To be honest I'm not 100% sure now if #28 was fixed earlier 🤔

[buh]

It was fixed, I used some hack to save additional offset with tabbar height.
But anyway one of our customer has another bug, that I couldn't reproduce and it was really annoying to fix. So, I decide to rewrite the ComposerView position in a new way. It's much more simple and easy to manage. I'm checking why it doesn't work for you.

[buh]

It's fixed v.1.5.3
Your ChatViewController should be embedded properly. The parent view controller at least should have correct safeAreaInsets.

I recommend you to use UIContainerView to embed it properly. Here is my example that works:

[mpodeszwa]

Hi @buh
Unfortunately it doesn't work for me. I tried using UIContainerView but it's still the same. Can you check out this branch?
https://github.com/mpodeszwa/stream-chat-swift/tree/bugfix/tab-input-offset

[buh]

Can't make a commit in your fork.
Please update Main.storyboard with this:
Main.storyboard.zip

[mpodeszwa]

Thanks for quick response, I downloaded your storyboard and it works, but only with translucent tab bar. If I turn this flag off, the input goes higher :/ I can't really turn on translucent tab bar on my app, because it doesn't go well with our designs :(

I checked on iPhone 8 Plus with iOS 11.4

[buh]

@mpodeszwa ok I’ll think how to fix it

[buh]

Please check master with the fix.

[mpodeszwa]

Awesome, works great now :) Thanks 👍