Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer is not visible if ChatViewController is offset from the top #6

Closed
mpodeszwa opened this issue Sep 2, 2019 · 2 comments
Closed
Assignees
Labels
🐞 Bug An issue or PR related to a bug

Comments

@mpodeszwa
Copy link
Contributor

What did you do?

On my application ChatViewController doesn't start from the top, it has offset.

What did you expect to happen?

When keyboard appears composer should move up so user can see his message while typing

What happened instead?

Composer is under keyboard, user can't see textfield when keyboard is open

Additional context

I created branch to show the problem:
https://github.com/mpodeszwa/stream-chat-swift/commits/demo/vc-offset

Simulator Screen Shot - iPhone Xs - 2019-09-02 at 15 10 27

Simulator Screen Shot - iPhone Xs - 2019-09-02 at 15 15 21

@tbarbugli tbarbugli added the 🐞 Bug An issue or PR related to a bug label Sep 2, 2019
@buh
Copy link
Contributor

buh commented Sep 2, 2019

Hi @mpodeszwa!
It's weird, I'll make a fix in the next release. Please fix your fork like that:
here:
https://github.com/GetStream/stream-chat-swift/blob/master/Sources/UI/User%20Story/Chat/Composer/ComposerView.swift#L261-L262

to:

let bottom: CGFloat = style.edgeInsets.bottom
    + max(0, height - (height > 0 ? .safeAreaBottom + self.toolBar.frame.height : 0))

@buh
Copy link
Contributor

buh commented Sep 3, 2019

Fixed in v.1.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants