Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3.2 LTS support ? #107

Closed
tkrevh opened this issue Aug 2, 2021 · 7 comments
Closed

Django 3.2 LTS support ? #107

tkrevh opened this issue Aug 2, 2021 · 7 comments
Assignees

Comments

@tkrevh
Copy link
Contributor

tkrevh commented Aug 2, 2021

Hello!

We're already using your chat, and are now starting to build functionalities around feeds as well.
Mainstream support for Django 3.1 expired in April this year (and extended one expires in December this year).
Django 3.2 is an LTS version, meaning it's expiring in April 2024.
Any chance you could bump up the version to Django 3.2?

@ferhatelmas
Copy link
Contributor

Definitely, we will do it ASAP.

@tkrevh
Copy link
Contributor Author

tkrevh commented Aug 12, 2021

@ferhatelmas any update on this? This is really high priority for us and it only requires a minimal change in

django = "django>=2.0,<3.2" # checked https://docs.djangoproject.com/en/dev/releases/3.1/#backwards-incompatible-3-1

to: django = "django>=2.0,<=3.2"

@ferhatelmas
Copy link
Contributor

On it, you should be able to use by tomorrow. Sorry for the latency.

@ferhatelmas ferhatelmas self-assigned this Aug 12, 2021
@tkrevh
Copy link
Contributor Author

tkrevh commented Aug 12, 2021

Thank you @ferhatelmas, we appreciate you 👏

@ferhatelmas
Copy link
Contributor

https://github.com/GetStream/stream-django/releases/tag/1.7.0

let me know if you see any issues.

@tkrevh
Copy link
Contributor Author

tkrevh commented Aug 13, 2021

@ferhatelmas yes, unfortuantely there is a serious issue - now django 3.2 can no longer start:
\lib\site-packages\stream_django\__init__.py", line 4, in <module> major, minor, _ = (int(i) for i in django.__version__.split('.')) ValueError: not enough values to unpack (expected 3, got 2)

Code is trying to unpack version 3.2 into three variables (underscore being the third one) and it fails on '3.2' string.
I would suggest replacing current line:

major, minor, _ = (int(i) for i in django.__version__.split('.'))

With:

version_list = [int(i) for i in django.__version__.split('.')]
major, minor = version_list[0], version_list[1]

@tkrevh
Copy link
Contributor Author

tkrevh commented Aug 13, 2021

I've also created a PR #109 for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants